sormas-api/src/main/resources/strings_it-CH.properties (1)

2098-2098: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Untranslated string left in English.

The updated messageSurveyResponseNotYetProcessed text remains in English rather than Italian, unlike most other entries in this locale file.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sormas-api/src/main/resources/strings_it-CH.properties` at line 2098, The
`messageSurveyResponseNotYetProcessed` entry in the Italian locale file is still
in English and needs to be translated to Italian. Update the value for
`messageSurveyResponseNotYetProcessed` in `strings_it-CH.properties` so it
matches the surrounding localized strings and keep the same key unchanged.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

sormas-backend/src/main/java/de/symeda/sormas/backend/patch/BusinessDtoFacade.java (1)

315-338: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove the large commented-out code block.

Lines 315–338 contain the entire previous implementation as a commented-out block. This clutters the method and will drift from reality as the active code evolves. If the alternative approach needs to be documented, replace it with a concise comment referencing the rationale or a design doc.

♻️ Proposed cleanup

 	public void save(`@NotNull` List<Tuple<Integer, EntityDto>> entityDtosByKey) {
-		// Be careful about "leaf-entities" that can change the case data:
-		// Person ; Immunization and VaccinationDto
-		/*
-		List<Tuple<Integer, EntityDto>> dtosInProgress = new ArrayList<>(entityDtosByKey);
-
-		//entityDtosByKey.stream()	.filter(dto -> dto.)
-
-		// ordering is important: root entities must be saved first to avoid OutdatedEntityException as leaf entities seem to update the case.
-		List<Tuple<Integer, EntityDto>>	 orderedRootEntities = entityDtosByKey.stream()
-			.filter(tuple -> leafAttacherDictionary.keySet().stream().noneMatch(leafClass -> leafClass.isInstance(tuple.getSecond())))
-			.sorted(Comparator.comparing(Tuple::getSecond, new EntityDtoTypeComparator()))
-			.collect(Collectors.toList());
-
-		orderedRootEntities.stream().map(Tuple::getSecond).forEach(this::saveDirectEntity);
-
-		// once it's done, leaf entities can be saved, as updating root entities will not break
-		leafAttacherDictionary.forEach((leafClass, attacher) -> {
-			List<Tuple<Integer, EntityDto>> leaves =
-				dtosInProgress.stream().filter(t -> leafClass.isInstance(t.getSecond())).collect(Collectors.toList());
-
-			leaves.forEach(leafTuple -> {
-				dtosInProgress.remove(leafTuple);
-				attacher.attachLeaf(leafTuple.getSecond(), leafTuple.getFirst(), dtosInProgress);
-			});
-		});
-		*/
 		List<Tuple<Integer, EntityDto>> dtosInProgress = new ArrayList<>(entityDtosByKey);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@sormas-backend/src/main/java/de/symeda/sormas/backend/patch/BusinessDtoFacade.java`
around lines 315 - 338, Remove the large commented-out implementation block from
BusinessDtoFacade and leave only a brief explanatory comment if needed; the
current commented code around dtosInProgress, orderedRootEntities, and
leafAttacherDictionary should be deleted to keep the method focused and prevent
stale logic from lingering. If the alternate approach still matters, replace it
with a short rationale comment or reference to the relevant design note instead
of preserving the full old implementation.

sormas-backend/src/test/java/de/symeda/sormas/patch/DataPatcherImplTest.java (2)

1022-1023: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Clarify the "outdated range" flakiness comment.

The comment "Might require changing outdated range to reproduce every time" suggests the test may be sensitive to entity version timestamps or timing. If this is a real concern, consider documenting the specific condition or stabilizing the test (e.g., by explicitly setting changeDate/uuid on the original case). If it's no longer relevant after the save-ordering change, remove the comment to avoid confusion.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sormas-backend/src/test/java/de/symeda/sormas/patch/DataPatcherImplTest.java`
around lines 1022 - 1023, The comment in DataPatcherImplTest is too vague about
the “outdated range” flakiness and should either be clarified or removed. Update
the test around the affected case-update scenario in DataPatcherImplTest to
describe the exact condition that makes reproduction timing-sensitive, or
stabilize the setup by explicitly controlling the relevant case fields such as
changeDate and uuid in the test data. If the save-ordering change has already
eliminated the issue, delete the outdated comment entirely so the intent of the
test is clear.

---

1020-1129: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add missing assertions for patched fields.

The test patches CaseData.followUpStatus (FOLLOW_UP), Immunization.validFrom ("2020-01-01"), Immunization.validUntil ("2035-01-01"), and Vaccination.vaccinationDate ("2024-05-01") but does not assert any of these values in the CHECK section. The validFrom/validUntil assertions are especially important — they determine whether the immunization is "valid" at the case report date, which drives the updateDeterminedVaccinationStatuses recompute. Without asserting them, a silent patch failure on those fields could still produce a green test.

Additionally, the VaccinationStatus.UNVACCINATED assertion at line 1121 doesn't prove the recompute side-effect occurred if createUnclassifiedCase already initializes vaccinationStatus to UNVACCINATED. Consider setting it to a different value before the patch to make the assertion meaningful.

♻️ Proposed additional assertions

 			// CaseData
 			() -> Assertions.assertEquals("some comment", actualCase.getQuarantineChangeComment()),
+			() -> Assertions.assertEquals(FollowUpStatus.FOLLOW_UP, actualCase.getFollowUpStatus()),
 
 			// Exposures

 			// Immunization / Vaccination
 			() -> Assertions.assertEquals(1, immunizations.size()),
 			() -> Assertions.assertEquals(ImmunizationStatus.ACQUIRED, immunizations.get(0).getImmunizationStatus()),
 			() -> Assertions.assertEquals(MeansOfImmunization.VACCINATION, immunizations.get(0).getMeansOfImmunization()),
+			() -> Assertions.assertEquals(
+				Date.from(LocalDate.parse("2020-01-01").atStartOfDay(ZoneId.systemDefault()).toInstant()),
+				immunizations.get(0).getValidFrom()),
+			() -> Assertions.assertEquals(
+				Date.from(LocalDate.parse("2035-01-01").atStartOfDay(ZoneId.systemDefault()).toInstant()),
+				immunizations.get(0).getValidUntil()),
 			() -> Assertions.assertEquals(1, immunizations.get(0).getVaccinations().size()),
 			() -> Assertions.assertEquals(Vaccine.COMIRNATY, immunizations.get(0).getVaccinations().get(0).getVaccineName()),
 			() -> Assertions.assertEquals("1", immunizations.get(0).getVaccinations().get(0).getVaccineDose()),
+			() -> Assertions.assertEquals(
+				Date.from(LocalDate.parse("2024-05-01").atStartOfDay(ZoneId.systemDefault()).toInstant()),
+				immunizations.get(0).getVaccinations().get(0).getVaccinationDate()),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sormas-backend/src/test/java/de/symeda/sormas/patch/DataPatcherImplTest.java`
around lines 1020 - 1129, The test method
patch_multipleEntities_caseDataExposureHospitalizationSymptoms is missing checks
for several patched values, so add assertions in the CHECK section for
CaseDataDto.getFollowUpStatus, ImmunizationDto.getValidFrom,
ImmunizationDto.getValidUntil, and VaccinationDto.getVaccinationDate. Also make
the VaccinationStatus assertion in the same test meaningful by initializing the
case to a different vaccination status before calling victim().patch, so the
later assertion on actualCase.getVaccinationStatus() proves
CaseService#updateDeterminedVaccinationStatuses was triggered.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

sormas-api/src/main/java/de/symeda/sormas/api/symptoms/SymptomsDto.java (1)

2962-2999: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

New Luxembourg-only symptom fields lack @SymptomGrouping.

lossOfAppetite, flatulence, smellyBurps, coughingAttacks, coughingAtNight, and abdominalCramps have no @SymptomGrouping annotation, unlike sibling fields added in the same block (eggyBurps, weightLoss, bloating) which use @SymptomGrouping(SymptomGroup.GASTROINTESTINAL/GENERAL). Without it, these fields won't be grouped correctly in the symptoms form UI.

♻️ Suggested fix

 	`@Diseases`({
 		CRYPTOSPORIDIOSIS,
 		GIARDIASIS,
 		RESPIRATORY_SYNCYTIAL_VIRUS })
+	`@SymptomGrouping`(SymptomGroup.GASTROINTESTINAL)
 	`@HideForCountriesExcept`(countries = {
 		CountryHelper.COUNTRY_CODE_LUXEMBOURG })
 	private SymptomState lossOfAppetite;
 
 	`@Diseases`({
 		GIARDIASIS })
+	`@SymptomGrouping`(SymptomGroup.GASTROINTESTINAL)
 	`@HideForCountriesExcept`(countries = {
 		CountryHelper.COUNTRY_CODE_LUXEMBOURG })
 	private SymptomState flatulence;
 
 	`@Diseases`({
 		GIARDIASIS })
+	`@SymptomGrouping`(SymptomGroup.GASTROINTESTINAL)
 	`@HideForCountriesExcept`(countries = {
 		CountryHelper.COUNTRY_CODE_LUXEMBOURG })
 	private SymptomState smellyBurps;
 
 	`@Diseases`({
 		PERTUSSIS })
+	`@SymptomGrouping`(SymptomGroup.RESPIRATORY)
 	`@HideForCountriesExcept`(countries = {
 		CountryHelper.COUNTRY_CODE_LUXEMBOURG })
 	private SymptomState coughingAttacks;
 
 	`@Diseases`({
 		PERTUSSIS })
+	`@SymptomGrouping`(SymptomGroup.RESPIRATORY)
 	`@HideForCountriesExcept`(countries = {
 		CountryHelper.COUNTRY_CODE_LUXEMBOURG })
 	private SymptomState coughingAtNight;
 
 	`@Diseases`({
 		CRYPTOSPORIDIOSIS,
 		GIARDIASIS })
+	`@SymptomGrouping`(SymptomGroup.GASTROINTESTINAL)
 	`@HideForCountriesExcept`(countries = {
 		CountryHelper.COUNTRY_CODE_LUXEMBOURG })
 	private SymptomState abdominalCramps;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@sormas-api/src/main/java/de/symeda/sormas/api/symptoms/SymptomsDto.java`
around lines 2962 - 2999, The Luxembourg-only symptom fields in SymptomsDto are
missing `@SymptomGrouping`, so they won’t appear in the same UI groups as the
neighboring symptoms. Add the appropriate `@SymptomGrouping` annotations to
lossOfAppetite, flatulence, smellyBurps, coughingAttacks, coughingAtNight, and
abdominalCramps, matching the existing pattern used by eggyBurps, weightLoss,
and bloating in the same block. Use the existing SymptomGroup constants to place
each field into the correct gastrointestinal or general group.